[Issue #3390] Remove agency_phone_number from Opportunity/Search API responses #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
approved these changes
Jan 6, 2025
mdragon
reviewed
Jan 6, 2025
| @@ -208,7 +208,7 @@ def validate_opportunity_summary(db_summary: OpportunitySummary, resp_summary: d | |||
| == resp_summary["applicant_eligibility_description"] | |||
| ) | |||
|
|
|||
| assert db_summary.agency_phone_number == resp_summary["agency_phone_number"] | |||
| assert "agency_phone_number" not in resp_summary | |||
There was a problem hiding this comment.
I like that you make this a negative assertion rather than just removing the check entirely.
mikehgrantsgov
deleted the
mikehgrantsgov/3390-remove-phone-number-from-opportunity-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3390
Time to review: 10 mins
Changes proposed
Remove
agency_phone_numberfrom opportunity GET and search API responses.Context for reviewers
Additional context in #3390 and associated ticket.
Additional information
See updated unit tests.