[Issue #2553] Cleanup v0 and v0.1 opportunity endpoints (backend/db) [3/3] #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
reviewed
Jan 6, 2025
api/src/db/migrations/versions/2025_01_06_remove_transfertopportunity_models.py
Outdated
Show resolved
Hide resolved
…//github.com/HHS/simpler-grants-gov into mikehgrantsgov/2553-cleanup-db-backend-tasts
github-actions
bot
requested review from
acouch,
andycochran,
btabaska,
coilysiren,
doug-s-nava and
widal001
as code owners
|
This looks good to me, but holding review until after our next prod deploy. Want to make sure this goes out in the subsequent release so that we delete all usages of the tables before deleting the tables themselves We're releasing tomorrow, so should be able to merge tomorrow afternoon? |
Sounds good! |
mikehgrantsgov
deleted the
mikehgrantsgov/2553-cleanup-db-backend-tasts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2553
Time to review: 10 mins
Changes proposed
Removes https://github.com/HHS/simpler-grants-gov/blob/main/api/src/db/models/transfer/topportunity_models.py + generate migrations to remove this table
Removes https://github.com/HHS/simpler-grants-gov/blob/main/api/src/data_migration/copy_oracle_data.py - the script that loads data into the transfer table (Note there will be some infra we want to remove to no longer schedule this job as well)
Transfer table removed
DB migration generated
Context for reviewers
Final PR to clean up v0 and v0.1 opportunity endpoints, along with supporting backend tasks.
Note, when PR #3409 is merged then the build errors will go away from this PR.
NOTE Do not merge until after next Prod deploy