3321/load attachment #3467
Merged
3321/load attachment #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
reviewed
Jan 8, 2025
… 3321/load-attachment
… 3321/load-attachment
… 3321/load-attachment
… 3321/load-attachment
… 3321/load-attachment
chouinar
requested changes
Jan 14, 2025
api/tests/src/api/opportunities_v1/test_opportunity_route_get.py
Outdated
Show resolved
Hide resolved
api/tests/src/search/backend/test_load_opportunities_to_index.py
Outdated
Show resolved
Hide resolved
api/tests/src/search/backend/test_load_opportunities_to_index.py
Outdated
Show resolved
Hide resolved
chouinar
reviewed
Jan 15, 2025
api/openapi.generated.yml
Outdated
| @@ -2092,7 +2092,7 @@ components: | |||
| format: uuid | |||
| description: The ID of the saved search | |||
| example: !!python/object:uuid.UUID | |||
| int: 82637552140693101888240202082641616217 | |||
| int: 223701124228644688372276000513924728179 | |||
There was a problem hiding this comment.
I'll have a fix for this shortly so it stops popping up on PRs
api/tests/src/search/backend/test_load_opportunities_to_index.py
Outdated
Show resolved
Hide resolved
…-grants-gov into 3321/load-attachment
…-grants-gov into 3321/load-attachment
chouinar
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #{3321}
Time to review: 10 mins
Changes proposed
Add
ENABLE_OPPORTUNITY_ATTACHMENT_PIPELINEfeature flagUse multi-attachment pipeline to bulk update opportunities into openSearch
Add/Update tests: Check attachment data was encoded
Ensure attachments are indexed properly
Context for reviewers
Additional information