Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2871] upgrade to node 22.13 #3481

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

doug-s-nava
Copy link
Collaborator

@doug-s-nava doug-s-nava commented Jan 10, 2025

Summary

Fixes #2871

Time to review: 20 mins

Changes proposed

All usages of Node in the application upgraded to latest 22 minor version (22.13). This includes:

  • github actions
  • Dockerfile base image
  • package.json engine (this will require local developers to be using the 22.13 <= in order to run npm installs)
  • node types package (upgraded to latest available, the versions for this package do not seem to be totally in line with actual node versions)

This also:

  • moves linting behavior into the next config from the package script (just for cleanliness)
  • upgrades the release Dockerfile base to bookworm from bullseye. This was already done for the build image, I think it was just an oversight that the release image was not upgraded as well.

Context for reviewers

Test Steps

  1. npm run dev and do a basic regression test
  2. VERIFY: app works as normal
  3. npm run build && npm start and do a basic regression test
  4. VERIFY: app works as normal
  5. update development.env to point to docker host and docker compose -f ./docker-compose-release.yml up --build and do a basic regression test
  6. VERIFY: app works as normal

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@doug-s-nava doug-s-nava force-pushed the dschrashun/2871-node-22 branch 2 times, most recently from 921f860 to 7b708a0 Compare January 10, 2025 15:25
@doug-s-nava doug-s-nava force-pushed the dschrashun/2871-node-22 branch from 7b708a0 to 17e77a1 Compare January 10, 2025 17:15
@doug-s-nava doug-s-nava marked this pull request as ready for review January 10, 2025 17:26
Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

@doug-s-nava doug-s-nava changed the title upgrade to node 22.13 [Issue #2871] upgrade to node 22.13 Jan 10, 2025
@doug-s-nava doug-s-nava merged commit 755ffbf into main Jan 10, 2025
19 checks passed
@doug-s-nava doug-s-nava deleted the dschrashun/2871-node-22 branch January 10, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade all frontend Node versions to latest v22
4 participants