[Unticketed] fix auth bug - allow non ssl cookies in non-prod #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
requested review from
acouch,
andycochran and
btabaska
as code owners
doug-s-nava
commented
Jan 13, 2025
| @@ -6,7 +6,7 @@ | |||
| "node": ">=22.13.0" | |||
| }, | |||
| "scripts": { | |||
| "all-checks": "npm run lint && npm run ts:check && npm run test && npm run build", | |||
| "all-checks": "npm run lint && npm run ts:check && npm run test && npm run build -- --no-lint", | |||
There was a problem hiding this comment.
incidental, but speeds things up a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unticketed
Time to review: 3 mins
Changes proposed
truein prod for now, as our lower environments are not set up with SSL yetContext for reviewers
Test steps
Additional information
It's pretty clear we need better logging on the NextJS app, creating tickets to deal with that now.