[Issue #3447] Create API endpoint for GET /users/:userID/save-searches #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
approved these changes
Jan 15, 2025
| @@ -297,3 +299,22 @@ def user_delete_saved_search( | |||
| ) | |||
|
|
|||
| return response.ApiResponse(message="Success") | |||
|
|
|||
|
|
|||
| @user_blueprint.get("/<uuid:user_id>/saved-searches") | |||
There was a problem hiding this comment.
I wonder if we should make this a POST endpoint - we might need to add some filters/sorting stuff (design dependent) and that would follow the same search request schema approach as our actual search endpoint.
Probably not that big a deal to switch later, but worth keeping in mind
There was a problem hiding this comment.
Good call. This will be an easy switch when the requirements arrive.
mikehgrantsgov
deleted the
mikehgrantsgov/3447-create-get-endpoint-saved-searches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3447
Time to review: 15 mins
Changes proposed
Create GET endpoint to return saved searched, accounting for enum values
Add unit tests
Context for reviewers
This is the final API required for saving user searches in this iteration.
Additional information
See unit tests