Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #3523] styling fixes for auth header #3541

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

doug-s-nava
Copy link
Collaborator

Summary

Fixes #3523

Time to review: 10 mins

Changes proposed

Some follow up styling fixes after initial launch of client side auth

  • css rule with magic number for lining up the mobile submenu removed
  • active hover state for mobile button no longer has white background
  • caret is white when active
  • dropdown items are lighter green on hover

Context for reviewers

  1. start on this branch with npm run dev
  2. visit http://localhost:3000 and log in
  3. VERIFY: at desktop width logged in header looks correct (see screenshots)
  4. VERIFY: at mobile width logged in header looks correct (see screenshots)

Additional information

Desktop

Screenshot 2025-01-15 at 3 38 48 PM
Screenshot 2025-01-15 at 3 38 38 PM

Mobile

Screenshot 2025-01-15 at 3 39 18 PM
Screenshot 2025-01-15 at 3 39 12 PM
Screenshot 2025-01-15 at 3 39 03 PM
Screenshot 2025-01-15 at 3 38 56 PM

@doug-s-nava doug-s-nava marked this pull request as ready for review January 15, 2025 20:40
@doug-s-nava doug-s-nava force-pushed the dschrashun/3523-auth-ui-follow-up branch from 99a8b5f to a233fff Compare January 15, 2025 20:42
Comment on lines 386 to 392
.usa-nav__primary {
.mobile-nav-dropdown-uncollapsed-override {
button:hover {
background-color: white;
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep all the .mobile-nav-dropdown-uncollapsed-override stuff together, I think you could move this inside the rule.

.mobile-nav-dropdown-uncollapsed-override {
  ... // all the default rules
  @include at-media("desktop") {
    button:hover {
      background-color: white;
    }
  }
}

andycochran
andycochran previously approved these changes Jan 16, 2025
acouch
acouch previously approved these changes Jan 17, 2025
@doug-s-nava doug-s-nava dismissed stale reviews from acouch and andycochran via f92aad0 January 17, 2025 17:34
@doug-s-nava doug-s-nava force-pushed the dschrashun/3523-auth-ui-follow-up branch from f92aad0 to 4fda8ae Compare January 17, 2025 18:58
@acouch acouch self-requested a review January 21, 2025 20:19
@doug-s-nava doug-s-nava merged commit 155184a into main Jan 21, 2025
8 checks passed
@doug-s-nava doug-s-nava deleted the dschrashun/3523-auth-ui-follow-up branch January 21, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend Auth UI Follow Ups
3 participants