-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #3520] Add the ability to only process a subset of opportunity attachments #3564
Conversation
…draft-delete-opp-attachments
…draft-delete-opp-attachments
…draft-delete-opp-attachments
…ar/3520-attachment-subset
…ar/3520-attachment-subset
…draft-delete-opp-attachments
…ar/3520-attachment-subset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the env var in terraform would be in another PR? Or does it need to be in TF? Either way, this one looks good.
Won't ever set in terraform, can set manually when I run the job during testing. Can run jobs with the A different command, but I ran: Set the overriden env vars in a file that I load with |
Summary
Fixes #3520
Time to review: 3 mins
Changes proposed
Add an env var that lets us run the opportunity attachment transform job only process a smaller set of attachments
Context for reviewers
Attachments are going to take a long time to run, and I wanted an easy way when testing to just tell the job to "stop after X attachments". This is that mechanism. It's pretty hacky/straightforward, just tell it to stop after processing a number of values, instead of finishing. It will still save these changes.
Additional information
If you want to test it locally, you can do the following.
First set the following env vars in override.env:
make volume-recreate
to drop your DB statemake console
and then:Finally:
make cmd args="data-migration load-transform --no-load --transform --no-set-current"