Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #3546] Add user notification table #3604

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

chouinar
Copy link
Collaborator

Summary

Fixes #3546

Time to review: 3 mins

Changes proposed

Adds a new table for tracking user notifications

Context for reviewers

First step in notifications work, an audit table of sorts for tracking when we send out notifications. Likely will adjust more as we build the feature out, but can help us track success/failures roughly

@chouinar chouinar requested a review from mdragon as a code owner January 22, 2025 20:09
Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@coilysiren
Copy link
Collaborator

O_O we are already working on this?!

@chouinar chouinar merged commit 7d220d1 into main Jan 23, 2025
@chouinar chouinar deleted the chouinar/3546-notification-table branch January 23, 2025 14:04
coilysiren added a commit that referenced this pull request Jan 24, 2025
## Summary
Fixes #{ISSUE}

### Time to review: __x mins__

## Motivation

Inspired by PRs like
#3604, which ping everyone
for a change that's only relevant to the

## Changes

The diff is rough, but the functional change is to group the codeowners
file by teams, and make the individual `documentation` folders be
codeowned by their respective teams.
DavidDudas-Intuitial pushed a commit that referenced this pull request Feb 7, 2025
## Summary
Fixes #{ISSUE}

### Time to review: __x mins__

## Motivation

Inspired by PRs like
#3604, which ping everyone
for a change that's only relevant to the

## Changes

The diff is rough, but the functional change is to group the codeowners
file by teams, and make the individual `documentation` folders be
codeowned by their respective teams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a notification table to track notifications we've done
4 participants