[Issue 185] Branch Convention and Release Workflow ADR #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
requested review from
andycochran,
daphnegold,
widal001 and
SammySteiner
acouch
changed the title
acouch
changed the title
SammySteiner
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Looks great. Thanks for documenting all of this.
Seems like the google docs are only accessible with a navapbc gmail, so we'd need to copy that info to the repo for it to be publicly accessible.
Never mind, I see you're documenting this in #431
documentation/decisions/2023-08-21-branch-conv-release-workflow.md
Outdated
Show resolved
Hide resolved
documentation/decisions/2023-08-21-branch-conv-release-workflow.md
Outdated
Show resolved
Hide resolved
documentation/decisions/2023-08-21-branch-conv-release-workflow.md
Outdated
Show resolved
Hide resolved
…ase-workflow.md to documentation/decisions/adr/2023-08-21-branch-conv-release-workflow.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #185
Time to review: 20 mins
Changes proposed
Adds ADR described in #185
Context for reviewers
This merges #185 and #112 .