Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 574] Search MVP deliverable spec #579

Merged
merged 23 commits into from
Nov 20, 2023
Merged

[Issue 574] Search MVP deliverable spec #579

merged 23 commits into from
Nov 20, 2023

Conversation

widal001
Copy link
Collaborator

@widal001 widal001 commented Oct 10, 2023 •
edited
Loading

Summary

Creates a deliverable spec for the Search MVP 30k ft deliverable

Fixes #574

Time to review: 10 mins

Changes proposed

What was added, updated, or removed in this PR.

Creates individual_milestones/search_mvp.md

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

It may be easier to view a rendered version of this deliverable spec.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@widal001 widal001 marked this pull request as draft October 10, 2023 21:52
@widal001 widal001 added the draft Not yet ready for review label Oct 10, 2023
acouch
acouch reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! Noting that the translation might be a large LOE, since I imagine we would need to integrate with some service that allows us to post english and ask for the spanish translation, or build a UI and content workflow to capture that.

widal001 and others added 2 commits October 30, 2023 17:28
@widal001 @sumiat
Apply suggestions from code review
3216ac1 
Updating spec with Sumi's suggestions

Co-authored-by: Sumi <[email protected]>
@widal001
refactor: updates search_mvp.md
58468d3 
- Removes Opportunity Listing as one of the requirements for Search MVP
- Indicates that we'll be sharing metrics in GitBook until we deliver a public measurement dashboard
@widal001 widal001 removed the draft Not yet ready for review label Nov 7, 2023
@widal001 widal001 marked this pull request as ready for review November 7, 2023 15:12
@widal001
Update search_mvp.md
7d8b9bd 
- Links to deliverable tickets where relevant
- Cleans up formatting of sections with questions and answers
@widal001 widal001 requested a review from sarahknoppA6 November 7, 2023 17:32
@EOKENAVA EOKENAVA self-requested a review November 7, 2023 17:34
sarahknoppA6
sarahknoppA6 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@sarahknoppA6 sarahknoppA6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

lucasmbrown-usds
lucasmbrown-usds approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@lucasmbrown-usds lucasmbrown-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, but overall looks good!

documentation/milestones/individual_milestones/search_mvp.md Outdated Show resolved Hide resolved
documentation/milestones/individual_milestones/search_mvp.md Outdated Show resolved Hide resolved
documentation/milestones/individual_milestones/search_mvp.md Outdated Show resolved Hide resolved
documentation/milestones/individual_milestones/search_mvp.md Outdated Show resolved Hide resolved
@widal001
Merge branch 'main' into issue-574-search-ui-deliverable-spec
a971985
@widal001
refactor: Renames search_mvp deliverable spec
965f6a8 
The milestones directory was renamed deliverables this moves the spec to
the new folder
@widal001
fix: Incorporates PR feedback
0a05c4a 
- Completes unfinished sentence
- Removes an unclear "(if necessary)" from acceptance criteria
- Fixes a typo in the acceptance criteria
- Updates terminology in the summary table at the top of the page
@widal001 widal001 merged commit 3a7fd6c into main Nov 20, 2023
@widal001 widal001 deleted the issue-574-search-ui-deliverable-spec branch November 20, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumiat sumiat sumiat left review comments

@acouch acouch acouch left review comments

@EOKENAVA EOKENAVA EOKENAVA approved these changes

@sarahknoppA6 sarahknoppA6 sarahknoppA6 approved these changes

@lucasmbrown-usds lucasmbrown-usds lucasmbrown-usds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Deliverable Spec]: Search MVP
6 participants
@widal001 @acouch @lucasmbrown-usds @sarahknoppA6 @sumiat @EOKENAVA