[Issue 617] Rename app and db in docker-compose #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
reviewed
Oct 31, 2023
acouch
approved these changes
Oct 31, 2023
acouch
pushed a commit
that referenced
this pull request
Oct 31, 2023
[Issue-617] Rename app and db in docker-compose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #617
Time to review: 5 mins
Changes proposed
Renamed the docker container for the app and DB to make them less generic.
Context for reviewers
Nothing too fancy, just updated the names and where we reference them.
Verified that everything works locally (
make init format lint test) and the API comes up and is usable (make run-logsgo to http://localhost:8080/docs ).If you check this out, I suggest you do
make clean-volumesto delete any existing DB volume as it was renamed.