Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 644] Add a GET /opportunity/:opportunity-id endpoint #660

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

chouinar
Copy link
Collaborator

@chouinar chouinar commented Nov 7, 2023

Summary

Fixes #644

Time to review: 5 mins

Changes proposed

Added a GET /opportunity/<opportunity_id> endpoint

Context for reviewers

Pretty basic endpoint, re-uses the opportunity response + db models we already have.

Additional information

Running locally:
Screenshot 2023-11-07 at 1 12 09 PM

@chouinar chouinar requested review from acouch and daphnegold November 7, 2023 18:19
@acouch
Copy link
Collaborator

acouch commented Nov 9, 2023

Noting that the ID in the ticket was {FON}, which corresponds to the opportunity_number in the API.

Nevermind, I can't confirm that all opportunities have funding opportunity numbers, so this works best for now.

@chouinar chouinar merged commit c9503dd into main Nov 9, 2023
@chouinar chouinar deleted the chouinar/get-opportunity branch November 9, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Create GET opportunties endpoint with basic query parameters
3 participants