[Issue 642] Filter to only opportunities that are not drafts

[chouinar]

Summary

Fixes #642

Time to review: 5 mins

Changes proposed

Made it so the search endpoint always filters to is_draft=False

Remove the ability for the user to filter by is_draft

Removed is_draft from the opportunity response model

Context for reviewers

We don't want to expose draft opportunities in the search, so always filter them.

Additional information

I populated my local DB with 50 opportunity records, randomly between is_draft True/False

select count(*) from topportunity where is_draft=False returns 21 records, so using the search endpoint with no filters should give the same result.

A request of:

{
  "paging": {
    "page_offset": 1,
    "page_size": 25
  },
  "sorting": {
    "order_by": "opportunity_id",
    "sort_direction": "ascending"
  }
}

Gives the following pagination info in the response:

"pagination_info": {
    "order_by": "opportunity_id",
    "page_offset": 1,
    "page_size": 25,
    "sort_direction": "ascending",
    "total_pages": 1,
    "total_records": 21
  }

[acouch]

This needs to be added to the api/src/services/opportunities/get_opportunities.py select query as well in order to keep is_draft == False opportunities from being shared in the GET endpoint.

[chouinar]

I'm assuming that at some point we'll be building out the ability to modify drafts, and we'd need the GET endpoint to return them, but we'll use whatever auth we build out to restrict whether someone can see a draft opportunity or not?

[acouch]

My current understanding is that the drafts should not be viewable to the general public, and that they would only be viewable by the grant org admins. Providing any drafts would require authenticating to the current system, which I imagine at this point is pretty far in the future.