[Issue 649] Rename opportunity table to use our naming schema #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
approved these changes
Nov 28, 2023
|
(nit): Make sure to follow PR title and commit format before merging. |
| # ### end Alembic commands ### | ||
|
|
||
|
|
||
| def downgrade(): |
There was a problem hiding this comment.
Does it make sense to clean this up and just remove the migration that created the t* tables, and reorder the order of the upgrades? Not sure the creation / deletion needs to stay in the history for something we never used.
There was a problem hiding this comment.
We could, but not until later. We need these delete migrations to delete the tables that exist already in our dev/prod environments (that, or we would need to manually delete the tables).
chouinar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #649
Time to review: 3 mins
Changes proposed
Rename the opportunity table from
topportunityas well as adjust several columns to use our namingContext for reviewers
This is intended as a precursor to some work where we'll setup the copy from DMS to our DB tables. As we can rename columns/tables with DMS, we can follow some of our conventions (not starting tables with
tand slightly clearer column names likeopportunity_numberinstead ofoppnumber).Note this deletes the existing table and makes a new one in the DB migrations, the code is renaming the tables, but Alembic can't detect renames (I think you can manually write the migrations to do renames, but not much point here). As we have nothing in the tables, this is fine, and makes sense to do before we start setting anything up for DMS.
Additional information
What the DB now looks like:
