[Issue 716] Add ProcessContent.tsx and process page update #788
Conversation
acouch
force-pushed
the
acouch/issue-716-process-intro
branch
from
6fd9ccd to
c909619
Compare
| @@ -54,7 +54,7 @@ const Breadcrumbs = ({ breadcrumbList }: Props) => { | |||
|
|
|||
| return ( | |||
| <GridContainer | |||
| className="padding-y-1 tablet:padding-y-3 desktop-lg:padding-y-6" | |||
| className="padding-top-1 tablet:padding-top-3 desktop-lg:padding-top-4" | |||
There was a problem hiding this comment.
I wonder if this should be margin so it collapses with adjacent elements with more/less margin.
| </p> | ||
| </Grid> | ||
| </Grid> | ||
| <Grid row gap className="flex-align-start"> |
There was a problem hiding this comment.
Sammy and I talked about how this bit might be a reusable component, as there's a similar pattern of boxes on the research page.
There was a problem hiding this comment.
But this is probably fine for now. We can swap to a component later.
| @@ -31,7 +32,7 @@ const Process: NextPage = () => { | |||
| /> | |||
| </FullWidthAlert> | |||
| <Breadcrumbs breadcrumbList={PROCESS_CRUMBS} /> | |||
| Process Placeholder | |||
| <ProcessContent /> | |||
There was a problem hiding this comment.
What are the benefits of putting the content in its own component, not just right in this page?
There was a problem hiding this comment.
Never mind. Duh, There are multiple sections of the page. This splits them out. I was confused because of the name of ProcessContent, thinking it was the content for the whole Process page.
|
Re: perfect pixels… We're not expecting an exact match. The Figma is just a mostly-accurate sketch. We'll just go with USWDS defaults. |
Summary
Fixes #716
Time to review: 10 mins
Changes proposed
Process intro section
Context for reviewers
NA
Additional information
The result isn't exactly a match on desktop b/c of the USWDS defaults: