[ Issues 722, 723, 724] Complete research page #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
approved these changes
Dec 7, 2023
SammySteiner
deleted the
sammysteiner/722-723-724-research-second-half
branch
andycochran
reviewed
Dec 7, 2023
Comment on lines
+71
to
+79
| <TextInput type="text" name="name" id="name" required /> | ||
| <Label htmlFor="LastName">Last Name</Label> | ||
| <TextInput type="text" name="LastName" id="LastName" /> | ||
| <div className="display-none"> | ||
| <Label htmlFor="hp">HP</Label> | ||
| <TextInput type="text" name="hp" id="hp" /> | ||
| </div> | ||
| <Label htmlFor="email">Email</Label> | ||
| <TextInput type="email" name="email" id="email" /> | ||
| <TextInput type="email" name="email" id="email" required /> |
There was a problem hiding this comment.
Per USWDS guidance… https://designsystem.digital.gov/components/form/#identifying-required-fields
We need to add a red asterisk to the labels for the required first name and email fields, and add "(optional)" to the label for the last name field.
There was a problem hiding this comment.
Sorry, I'm late to this. I'll open a ticket…
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #722 #723 #724
Time to review: 15 mins
Changes proposed
Completed the Research page
Additional information
desktop:
mobile:
