[Issue 633] Add Alsia and Michael to project #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
reviewed
Dec 13, 2023
.github/CODEOWNERS
Outdated
Comment on lines
1
to
2
| # We are limiting this to 3 engineers and choosing not to select "Require review from Code Owners." | ||
| @daphnegold @SammySteiner @acouch | ||
| @acouch @aplybeah @chouinar @SammySteiner |
There was a problem hiding this comment.
Should we adjust this comment?
docker-compose-ssl.yml
Outdated
| @@ -0,0 +1,42 @@ | |||
| version: '3' | |||
There was a problem hiding this comment.
Added by oopsies. Removing.
acouch
force-pushed
the
acouch/issue-633-add-a-m
branch
from
724186c to
683e571
Compare
|
@chouinar thanks for the review. Per yr question, it should auto-assign. The file is "valid":
🤔 |
We might need to make it so a code owner needs to approve the PR to merge for it to automatically work? |
chouinar
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #633
Time to review: 5 mins
Changes proposed
Add new team members to MAINTAINERS and CODEOWNERS