Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 888] Make CTA links bold on process page #911

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[Issue 888] Make CTA links bold on process page #911

merged 1 commit into from
Dec 14, 2023

Conversation

andycochran
Copy link
Collaborator

Summary

Partially addresses #888

Time to review: 1 mins

Changes proposed

  • Make links bold (to match Figma)

@andycochran andycochran mentioned this pull request Dec 14, 2023
Closed
SammySteiner
SammySteiner approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@SammySteiner SammySteiner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but another way to approach this, since we're using the i18n Trans component, we can add className="text-bold" to the email and github component on line 27 and line 47 of frontend/src/pages/content/ProcessInvolved.tsx

@andycochran
Copy link
Collaborator Author

I think the HTML is more a11y-compliant.

@andycochran andycochran merged commit ab08948 into main Dec 14, 2023
8 checks passed
@andycochran andycochran deleted the andycochran/888--bold-process-links branch December 14, 2023 20:13
SammySteiner pushed a commit that referenced this pull request Dec 22, 2023
@andycochran @SammySteiner
[Issue 888] Make CTA links bold on process page (#911)
8f9ba0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammySteiner SammySteiner SammySteiner approved these changes

@acouch acouch Awaiting requested review from acouch acouch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andycochran @SammySteiner