[Issue 893] Make opportunity API model have more fields from the DB #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
approved these changes
Dec 18, 2023
SammySteiner
pushed a commit
that referenced
this pull request
Dec 22, 2023
…917) [Issue 893] Make opportunity API model have more fields from the DB --------- Co-authored-by: nava-platform-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #893
Time to review: 5 mins
Changes proposed
Return a few additional fields from the opportunity table in the opportunity search + get endpoints.
Updated the DB factory to only add a category explanation if the category is
O(other)Context for reviewers
As we currently have things setup the DB model is converted to JSON directly, so we just need to update the response model to have it get returned in response.
Additional information
Some examples of responses from the API endpoints: