Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 894] analytics documentation #984

Merged
merged 22 commits into from
Jan 22, 2024
Merged

Conversation

widal001
Copy link
Collaborator

@widal001 widal001 commented Jan 8, 2024

Summary

Reorganizes and expands the documentation to reflect the structure of docs for API and Frontend sections of the codebase.

Fixes #894

Time to review: 15 mins

Changes proposed

What was added, updated, or removed in this PR.

  • Adds the following docs to documentation/analytics/
    • development.md How to install and run the analytics package locally and complete common tasks, like:
      • Adding a new dataset
      • Adding a new metric
    • formatting-and-linting.md Describes the tools used for linting and formatting the code
    • testing.md Describes how to run and write tests for the test suite
    • usage.md Describes how to run the report and view the results
    • technical-overview.md Describes the key technologies used in the project
    • metrics/Section with more detailed explanations of how metrics are calculated, including expected inputs and outputs
  • Reorganizes docs in analytics/README.md

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

I tried to mirror the structure of the docs for the other sections of the codebase:

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@widal001 widal001 added the draft Not yet ready for review label Jan 8, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python analytics labels Jan 12, 2024
@widal001 widal001 marked this pull request as ready for review January 16, 2024 16:12
@widal001 widal001 removed the draft Not yet ready for review label Jan 16, 2024
Copy link
Contributor

@AlexanderStephensonUSDS AlexanderStephensonUSDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the inclusion of example data to walk through the metrics.

As we think about future metrics to the project, is coupling steps with examples the approach we want to take for all metrics?

Some reasons for the current structure as I see it:

  • an individual looking at the metric gets a clear understanding of the example calculation steps required
  • an individual sees how the inputs connect to the outputs.
  • Explanation of step happens with an example.

Some reasons against the current structure:

  • Readability right now requires scrolling through large amount of text that might not be essential for understanding. The percent-complete metric right now is the same metric to two different examples.
  • The steps lack a table of contents, also affecting readability.

An intermediate compromise might be to have a section that is the brief "how" section of the metric calculation itself (e.g. mean = sum(x)/len(x)) and then the examples are split into calculation steps.

The analytics.etl sub-package was renamed analytics.integrations
This fixes stale references to the old name in docs
Hides example inputs and outputs using the <details> tags and adds summary
Copy link
Collaborator

@lucasmbrown-usds lucasmbrown-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely thorough and comprehensive! Kudos!

analytics/README.md Show resolved Hide resolved
analytics/README.md Show resolved Hide resolved
documentation/analytics/development.md Show resolved Hide resolved
documentation/analytics/development.md Show resolved Hide resolved
documentation/analytics/development.md Outdated Show resolved Hide resolved
documentation/analytics/metrics/README.md Show resolved Hide resolved
@widal001 widal001 merged commit ed81c9d into main Jan 22, 2024
2 checks passed
@widal001 widal001 deleted the issue-894-analytics-documentation branch January 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics documentation Improvements or additions to documentation python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Analytics - Add documentation explaining how the metrics are calculated
3 participants