-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 894] analytics documentation #984
Conversation
Adds an analytics section to docs to mirror structure of API and frontend
Removes sections of the README that have been moved to analytics/docs and links to those new docs in the main README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the inclusion of example data to walk through the metrics.
As we think about future metrics to the project, is coupling steps with examples the approach we want to take for all metrics?
Some reasons for the current structure as I see it:
- an individual looking at the metric gets a clear understanding of the example calculation steps required
- an individual sees how the inputs connect to the outputs.
- Explanation of step happens with an example.
Some reasons against the current structure:
- Readability right now requires scrolling through large amount of text that might not be essential for understanding. The percent-complete metric right now is the same metric to two different examples.
- The steps lack a table of contents, also affecting readability.
An intermediate compromise might be to have a section that is the brief "how" section of the metric calculation itself (e.g. mean = sum(x)/len(x)) and then the examples are split into calculation steps.
The analytics.etl sub-package was renamed analytics.integrations This fixes stale references to the old name in docs
Hides example inputs and outputs using the <details> tags and adds summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extremely thorough and comprehensive! Kudos!
Summary
Reorganizes and expands the documentation to reflect the structure of docs for API and Frontend sections of the codebase.
Fixes #894
Time to review: 15 mins
Changes proposed
documentation/analytics/
development.md
How to install and run the analytics package locally and complete common tasks, like:formatting-and-linting.md
Describes the tools used for linting and formatting the codetesting.md
Describes how to run and write tests for the test suiteusage.md
Describes how to run the report and view the resultstechnical-overview.md
Describes the key technologies used in the projectmetrics/
Section with more detailed explanations of how metrics are calculated, including expected inputs and outputsanalytics/README.md
Context for reviewers
I tried to mirror the structure of the docs for the other sections of the codebase:
api/
anddocumentation/api/
frontend/
anddocumentation/frontend/
Additional information