Skip to content

Commit

Permalink
Merge tag 'v2016.2' into release-2016-fda
Browse files Browse the repository at this point in the history
  • Loading branch information
BerndDoser committed Feb 14, 2017
2 parents a84752a + 907c158 commit 8349845
Show file tree
Hide file tree
Showing 58 changed files with 1,065 additions and 407 deletions.
41 changes: 15 additions & 26 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,6 @@ gmx_dependent_cache_variable(GMX_SIMD_REF_DOUBLE_WIDTH "Reference SIMD double pr

option(GMX_BROKEN_CALLOC "Work around broken calloc()" OFF)
mark_as_advanced(GMX_BROKEN_CALLOC)
option(GMX_LOAD_PLUGINS "Compile with plugin support, needed to read VMD supported file formats" ON)
mark_as_advanced(GMX_LOAD_PLUGINS)

option(GMX_OPENMP "Enable OpenMP-based multithreading" ON)

Expand Down Expand Up @@ -505,8 +503,18 @@ if(DEFINED HWLOC_LIBRARIES)
set(Hwloc_FIND_QUIETLY TRUE)
endif()
find_package(Hwloc 1.5)
if(HWLOC_FOUND)
set(GMX_HWLOC_DEFAULT ON)
if (HWLOC_FOUND)
if (HWLOC_LIBRARIES MATCHES ".a$")
set(_STATIC_HWLOC TRUE)
endif()

gmx_check_if_changed(HWLOC_FOUND_CHANGED HWLOC_FOUND)
if (_STATIC_HWLOC AND HWLOC_FOUND_CHANGED)
message(STATUS "Static hwloc library found, will not attempt using it as it could lead to link-time errors. To use the detected library, manually set GMX_HWLOC=ON and you will likely have to pass appropriate linker flags too to satisfy the link-time dependencies of your hwloc library. Try \"pkg-config --libs --static hwloc\" for suggestions on what you will need.")
set(GMX_HWLOC_DEFAULT OFF)
else()
set(GMX_HWLOC_DEFAULT ON)
endif()
else()
set(GMX_HWLOC_DEFAULT OFF)
endif()
Expand Down Expand Up @@ -705,32 +713,13 @@ include(gmxManageFFTLibraries)

include(gmxManageLinearAlgebraLibraries)

# Whether GROMACS will really try to compile support for VMD plugins
set(GMX_USE_PLUGINS OFF)
include(gmxManagePluginSupport)

if(GMX_LOAD_PLUGINS)
if(NOT WIN32)
# Native Windows does not have, nor need dlopen
include(gmxTestdlopen)
gmx_test_dlopen(HAVE_DLOPEN)
endif()

# so, should we use plug-ins?
if(WIN32 OR (HAVE_DLOPEN AND BUILD_SHARED_LIBS))
if(NOT VMD_QUIETLY)
MESSAGE(STATUS "Using dynamic plugins (e.g VMD-supported file formats)")
endif()
if (GMX_USE_PLUGINS)
if(NOT GMX_VMD_PLUGIN_PATH)
find_package(VMD)
find_package(VMD)
endif()
set(GMX_USE_PLUGINS ON)
list(APPEND GMX_EXTRA_LIBRARIES ${CMAKE_DL_LIBS}) # magic cross-platform pre-set variable for dlopen library
set(PKG_DL_LIBS "-l${CMAKE_DL_LIBS}")
else()
set(PKG_DL_LIBS)
endif()
endif()
set(VMD_QUIETLY TRUE CACHE INTERNAL "")

# Link real-time library for POSIX timers. The check for clock_gettime
# confirms the linkability of rt.
Expand Down
41 changes: 41 additions & 0 deletions admin/builds/get-version-info.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#
# This file is part of the GROMACS molecular simulation package.
#
# Copyright (c) 2016, by the GROMACS development team, led by
# Mark Abraham, David van der Spoel, Berk Hess, and Erik Lindahl,
# and including many others, as listed in the AUTHORS file in the
# top-level source directory and at http://www.gromacs.org.
#
# GROMACS is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public License
# as published by the Free Software Foundation; either version 2.1
# of the License, or (at your option) any later version.
#
# GROMACS is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with GROMACS; if not, see
# http://www.gnu.org/licenses, or write to the Free Software Foundation,
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
# If you want to redistribute modifications to GROMACS, please
# consider that scientific software is very special. Version
# control is crucial - bugs must be traceable. We will be happy to
# consider code for inclusion in the official distribution, but
# derived work must not be called official GROMACS. Details are found
# in the README & COPYING files - if they are missing, get the
# official version at http://www.gromacs.org.
#
# To help us fund GROMACS development, we humbly ask that you cite
# the research papers on the package. Check out http://www.gromacs.org.

import json

def do_build(context):
cmd = [context.env.cmake_command, '-P', 'cmake/gmxVersionInfo.cmake']
info_json = context.run_cmd(cmd, use_output=True)
values = json.loads(info_json)
context.set_version_info(values['version'], values['regressiontest-md5sum'])
5 changes: 0 additions & 5 deletions admin/builds/gromacs.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,6 @@ def do_build(context):
regressiontests_path = context.workspace.get_project_dir(Project.REGRESSIONTESTS)

if context.job_type == JobType.RELEASE:
# TODO: Consider using REGRESSIONTEST_DOWNLOAD here, after refactoring
# it to make that possible. Or use some other mechanism to check the
# MD5 of the regressiontests tarball (also taking into account the -dev
# builds where the hardcoded value in gmxVersionInfo.cmake is not
# accurate).
cmake_opts['REGRESSIONTEST_PATH'] = regressiontests_path
else:
if context.opts.mdrun_only:
Expand Down
57 changes: 57 additions & 0 deletions admin/builds/update-regtest-hash.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
#
# This file is part of the GROMACS molecular simulation package.
#
# Copyright (c) 2016, by the GROMACS development team, led by
# Mark Abraham, David van der Spoel, Berk Hess, and Erik Lindahl,
# and including many others, as listed in the AUTHORS file in the
# top-level source directory and at http://www.gromacs.org.
#
# GROMACS is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public License
# as published by the Free Software Foundation; either version 2.1
# of the License, or (at your option) any later version.
#
# GROMACS is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with GROMACS; if not, see
# http://www.gnu.org/licenses, or write to the Free Software Foundation,
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
# If you want to redistribute modifications to GROMACS, please
# consider that scientific software is very special. Version
# control is crucial - bugs must be traceable. We will be happy to
# consider code for inclusion in the official distribution, but
# derived work must not be called official GROMACS. Details are found
# in the README & COPYING files - if they are missing, get the
# official version at http://www.gromacs.org.
#
# To help us fund GROMACS development, we humbly ask that you cite
# the research papers on the package. Check out http://www.gromacs.org.

import json

extra_options = {
'md5sum': Option.string
}

def do_build(context):
info_path = 'cmake/gmxVersionInfo.cmake'
cmd = [context.env.cmake_command, '-P', info_path]
info_json = context.run_cmd(cmd, use_output=True)
values = json.loads(info_json)
old_md5sum = values['regressiontest-md5sum']
new_md5sum = context.opts.md5sum
if new_md5sum != old_md5sum:
context.replace_in_file(info_path, r'set\(REGRESSIONTEST_MD5SUM "(\w*)"',
lambda x: do_replacement(x, new_md5sum))
context.workspace.upload_revision(project=Project.GROMACS, file_glob=info_path)

def do_replacement(match, new_md5sum):
result = match.group(0)
start = match.start(1) - match.start(0)
end = match.end(1) - match.end(0)
return result[:start] + new_md5sum + result[end:]
4 changes: 2 additions & 2 deletions cmake/FindFFTW.cmake
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#
# This file is part of the GROMACS molecular simulation package.
#
# Copyright (c) 2012,2013,2014,2015, by the GROMACS development team, led by
# Copyright (c) 2012,2013,2014,2015,2016, by the GROMACS development team, led by
# Mark Abraham, David van der Spoel, Berk Hess, and Erik Lindahl,
# and including many others, as listed in the AUTHORS file in the
# top-level source directory and at http://www.gromacs.org.
Expand Down Expand Up @@ -152,7 +152,7 @@ if (${FFTW}_FOUND)
endif()

#Verify FFTW is compiled with fPIC (necessary for shared libraries)
if (CMAKE_OBJDUMP AND CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" AND BUILD_SHARED_LIBS AND NOT CYGWIN)
if (CMAKE_OBJDUMP AND CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" AND BUILD_SHARED_LIBS AND NOT CYGWIN AND NOT APPLE)
execute_process(COMMAND ${CMAKE_OBJDUMP} --reloc ${${FFTW}_LIBRARY} OUTPUT_VARIABLE ${FFTW}_OBJDUMP)
if (${${FFTW}_OBJDUMP} MATCHES "R_X86_64" #Should always be true for static libraries. Checks that objdump works properly and that the library isn't dynamic
AND NOT ${${FFTW}_OBJDUMP} MATCHES "R_X86_64_PLT32")
Expand Down
5 changes: 3 additions & 2 deletions cmake/gmxCFlags.cmake
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#
# This file is part of the GROMACS molecular simulation package.
#
# Copyright (c) 2009,2010,2011,2012,2013,2014,2015,2016, by the GROMACS development team, led by
# Copyright (c) 2009,2010,2011,2012,2013,2014,2015,2016,2017, by the GROMACS development team, led by
# Mark Abraham, David van der Spoel, Berk Hess, and Erik Lindahl,
# and including many others, as listed in the AUTHORS file in the
# top-level source directory and at http://www.gromacs.org.
Expand Down Expand Up @@ -240,7 +240,8 @@ macro (gmx_c_flags)
if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 15.00.00)
GMX_TEST_CXXFLAG(CXXFLAGS_WARN_OLD /wd193 GMXC_CXXFLAGS)
endif()
GMX_TEST_CXXFLAG(CXXFLAGS_WARN "/W3 /wd177 /wd271 /wd304 /wd383 /wd424 /wd444 /wd522 /wd593 /wd869 /wd981 /wd1418 /wd1419 /wd1572 /wd1599 /wd2259 /wd2415 /wd2547 /wd2557 /wd3280 /wd3346 /wd1782 /wd2282" GMXC_CXXFLAGS)
#809: exception specification for virtual function X is incompatible with that of overridden function
GMX_TEST_CXXFLAG(CXXFLAGS_WARN "/W3 /wd177 /wd271 /wd304 /wd383 /wd424 /wd444 /wd522 /wd593 /wd809 /wd869 /wd981 /wd1418 /wd1419 /wd1572 /wd1599 /wd2259 /wd2415 /wd2547 /wd2557 /wd3280 /wd3346 /wd1782 /wd2282" GMXC_CXXFLAGS)
endif()
GMX_TEST_CXXFLAG(CXXFLAGS_OPT "/Qip" GMXC_CXXFLAGS_RELEASE)
endif()
Expand Down
6 changes: 4 additions & 2 deletions cmake/gmxDetectSimd.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,12 @@ function(gmx_suggest_simd _suggested_simd)
message(STATUS "Detecting best SIMD instructions for this CPU")

# Get CPU SIMD properties information
set(_compile_definitions "${GCC_INLINE_ASM_DEFINE} -I${CMAKE_SOURCE_DIR}/src -DGMX_CPUINFO_STANDALONE ${GMX_STDLIB_CXX_FLAGS}")
if(GMX_TARGET_X86)
set(_compile_definitions "${_compile_definitions} -DGMX_TARGET_X86")
set(GMX_TARGET_X86_VALUE 1)
else()
set(GMX_TARGET_X86_VALUE 0)
endif()
set(_compile_definitions "${GCC_INLINE_ASM_DEFINE} -I${CMAKE_SOURCE_DIR}/src -DGMX_CPUINFO_STANDALONE ${GMX_STDLIB_CXX_FLAGS} -DGMX_TARGET_X86=${GMX_TARGET_X86_VALUE}")

# Prepare a default suggestion
set(OUTPUT_SIMD "None")
Expand Down
98 changes: 98 additions & 0 deletions cmake/gmxManagePluginSupport.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
#
# This file is part of the GROMACS molecular simulation package.
#
# Copyright (c) 2016, by the GROMACS development team, led by
# Mark Abraham, David van der Spoel, Berk Hess, and Erik Lindahl,
# and including many others, as listed in the AUTHORS file in the
# top-level source directory and at http://www.gromacs.org.
#
# GROMACS is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public License
# as published by the Free Software Foundation; either version 2.1
# of the License, or (at your option) any later version.
#
# GROMACS is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with GROMACS; if not, see
# http://www.gnu.org/licenses, or write to the Free Software Foundation,
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#
# If you want to redistribute modifications to GROMACS, please
# consider that scientific software is very special. Version
# control is crucial - bugs must be traceable. We will be happy to
# consider code for inclusion in the official distribution, but
# derived work must not be called official GROMACS. Details are found
# in the README & COPYING files - if they are missing, get the
# official version at http://www.gromacs.org.
#
# To help us fund GROMACS development, we humbly ask that you cite
# the research papers on the package. Check out http://www.gromacs.org.

include(gmxOptionUtilities)

# Sets GMX_USE_PLUGINS=ON in the parent scope if the toolchain and
# user selections permit the build to support plugin loading.
function(gmx_manage_plugin_support)
gmx_option_trivalue(GMX_LOAD_PLUGINS "Compile with plugin support, needed to read VMD supported file formats" AUTO)
mark_as_advanced(GMX_LOAD_PLUGINS)

# Find out if non-Windows builds can support plugins. Native Windows
# neither needs nor has library support.
if (NOT WIN32)
# TODO Make a proper find_package for dlopen to find
# dlfcn.h. The CMake variable CMAKE_DL_LIBS works magically
# for the library, however.
include(gmxTestdlopen)
gmx_test_dlopen(HAVE_DLOPEN)
endif()

# Keep the status line quiet unless something relevant has
# changed.
gmx_check_if_changed(EMIT_STATUS_MESSAGES GMX_LOAD_PLUGINS BUILD_SHARED_LIBS HAVE_DLOPEN)

# Whether GROMACS will really try to compile support for VMD
# plugins.
set(GMX_USE_PLUGINS OFF)

# Plugins are supported natively on Windows
if (WIN32 OR (BUILD_SHARED_LIBS AND HAVE_DLOPEN))
set(GMX_USE_PLUGINS ${GMX_LOAD_PLUGINS})
elseif(GMX_LOAD_PLUGINS)
# Can't support plugins for some reason. If the user required
# plugins, emit fatal errors. Otherwise, emit status messages
# for AUTO and be silent for OFF.
set(message "")
if (NOT HAVE_DLOPEN)
set(message "${message}dlopen() support for using dynamic plugins for VMD-supported file formats is missing. ")
endif()
if(NOT BUILD_SHARED_LIBS)
set(message "${message}GROMACS only supports plugins in a build that uses shared libraries, which can be disabled for various reasons. BUILD_SHARED_LIBS=on and a toolchain that supports dynamic linking is required. (Hint: GMX_PREFER_STATIC_LIBS and GMX_BUILD_MDRUN_ONLY can influence the default BUILD_SHARED_LIBS, so if you need plugins, reconsider those choices.) ")
endif()
if (GMX_LOAD_PLUGINS_FORCE)
message(FATAL_ERROR "${message}Cannot build with GMX_LOAD_PLUGINS=${GMX_LOAD_PLUGINS}.")
endif()
if (GMX_LOAD_PLUGINS_AUTO AND EMIT_STATUS_MESSAGES)
message(STATUS "${message}")
endif()
endif()

if(EMIT_STATUS_MESSAGES)
if(GMX_USE_PLUGINS)
MESSAGE(STATUS "Using dynamic plugins (e.g VMD-supported file formats)")
else()
MESSAGE(STATUS "Not using dynamic plugins (e.g VMD-supported file formats)")
endif()
endif()
set(GMX_USE_PLUGINS ${GMX_USE_PLUGINS} PARENT_SCOPE)
endfunction()

gmx_manage_plugin_support()

if(GMX_USE_PLUGINS)
list(APPEND GMX_EXTRA_LIBRARIES ${CMAKE_DL_LIBS}) # magic cross-platform pre-set variable for dlopen library
set(PKG_DL_LIBS "-l${CMAKE_DL_LIBS}")
endif()
6 changes: 4 additions & 2 deletions cmake/gmxSetBuildInformation.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,12 @@ macro(gmx_set_build_information)

if(NOT CMAKE_CROSSCOMPILING)
# Get CPU information, e.g. for deciding what SIMD support probably exists
set(_compile_definitions "${GCC_INLINE_ASM_DEFINE} -I${CMAKE_SOURCE_DIR}/src -DGMX_CPUINFO_STANDALONE ${GMX_STDLIB_CXX_FLAGS}")
if(GMX_TARGET_X86)
set(_compile_definitions "${_compile_definitions} -DGMX_TARGET_X86")
set(GMX_TARGET_X86_VALUE 1)
else()
set(GMX_TARGET_X86_VALUE 0)
endif()
set(_compile_definitions "${GCC_INLINE_ASM_DEFINE} -I${CMAKE_SOURCE_DIR}/src -DGMX_CPUINFO_STANDALONE ${GMX_STDLIB_CXX_FLAGS} -DGMX_TARGET_X86=${GMX_TARGET_X86_VALUE}")

set(GMX_BUILDINFORMATION_BINARY "${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/GmxBuildInformation${CMAKE_EXECUTABLE_SUFFIX}")
set(LINK_LIBRARIES "${GMX_STDLIB_LIBRARIES}")
Expand Down
3 changes: 2 additions & 1 deletion cmake/gmxTestCXX11.cmake
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#
# This file is part of the GROMACS molecular simulation package.
#
# Copyright (c) 2012,2013,2014,2015,2016, by the GROMACS development team, led by
# Copyright (c) 2012,2013,2014,2015,2016,2017, by the GROMACS development team, led by
# Mark Abraham, David van der Spoel, Berk Hess, and Erik Lindahl,
# and including many others, as listed in the AUTHORS file in the
# top-level source directory and at http://www.gromacs.org.
Expand Down Expand Up @@ -102,6 +102,7 @@ extern template void someFunction<int>();
int main() {
// Test nullptr
double *x = nullptr;
(void)x; // Suppressing unused variable warning
// Test range-based for loops
int array[5] = { 1, 2, 3, 4, 5 };
for (int& x : array)
Expand Down
Loading

0 comments on commit 8349845

Please sign in to comment.