Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding functionality to allow for multiple service calls. This preven… #11

Merged
merged 2 commits into from
Nov 8, 2016

Conversation

vchu
Copy link
Contributor

@vchu vchu commented Nov 8, 2016

…ts the listener from wiping the last speech command

…ts the listener from wiping the last speech command
@vchu
Copy link
Contributor Author

vchu commented Nov 8, 2016

@yuchen93 @jainajinkya

Hi folks, Andrea mentioned that there seem to be an issue with multiple speech calls being a possible thing that breaks hello world.

This might not be related at all, but just FYI - I've added in a parameter in the config file that allows several service calls to the same listener. Basically, if the flag is set to true, then the listener doesn't check if the command has been provided before. It literally just returns the last speech command it heard.

@vchu
Copy link
Contributor Author

vchu commented Nov 8, 2016

Also FYI - I was able to run the hello world demo in simulation without any errors. I am on the poli_config branch of vector_v1. Maybe something to do with that as opposed to speech?

@yuchen93
Copy link

yuchen93 commented Nov 8, 2016

We tried the hello world code Asif gave us and it is different from the one we had. That worked so we compared the code and found it was because the speech node being initialized twice in our version.

Yuchen

Sent from my iPhone

On Nov 8, 2016, at 4:27 PM, Vivian Chu [email protected] wrote:

Also FYI - I was able to run the hello world demo in simulation without any errors. I am on the poli_config branch of vector_v1. Maybe something to do with that as opposed to speech?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@vchu
Copy link
Contributor Author

vchu commented Nov 8, 2016

Got it. We really need to at some point have a central committed version of working. The one in si-machines works, but passing around versions via zip file shouldn't be done in the long run...

@mrana6 @jainajinkya Just FYI - unless someone puts the latest cleaned up version somewhere, I'm not going to be able to help if anything ever breaks. I normally when committing something that will break hello world, go back and check with the version we have in si-machines, but that won't work since everyone doesn't have access to that repo.

@vchu vchu merged commit 08555ae into master Nov 8, 2016
@vchu vchu deleted the multiple_speech_calls branch November 8, 2016 23:47
@mrana6
Copy link

mrana6 commented Nov 9, 2016

@vchu I have the latest version under gt-rail-internal/HLP-R/hlpr_hello_world for the time being. I am 80% done with cleaning up and commenting the code. This is the same version @yuchen93 and @jainajinkya are using and they have access to it as well.

@vchu
Copy link
Contributor Author

vchu commented Nov 10, 2016

@mrana6 Great - good to know. I'll make sure any changes then I commit work with that version. Do @yuchen93 and @jainajinkya have access to that repo? If anything needs to be changed API wise, I'll directly change it in that repo in the future (until it gets promoted)

@mrana6
Copy link

mrana6 commented Nov 10, 2016

Yes they do have access as far as I know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants