Skip to content

Commit

Permalink
fix(event-display): fix too many params for hits
Browse files Browse the repository at this point in the history
  • Loading branch information
9inpachi committed May 24, 2021
1 parent 1e92c1d commit 8b994a7
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ export class PhoenixObjects {
private static hitsToPoints(
pointPos: any,
hitsParams: any,
hitParamsClone: any
_hitParamsClone: any
): Object3D {
const geometry = new BufferGeometry();
geometry.setAttribute('position', new BufferAttribute(pointPos, 3));
Expand All @@ -302,7 +302,9 @@ export class PhoenixObjects {
});
// object
const pointsObj = new Points(geometry, material);
pointsObj.userData = Object.assign({}, hitParamsClone);
// Disabling for now because the data isn't readable on object selection.
// pointsObj.userData = Object.assign({}, hitParamsClone);
pointsObj.userData = {};
pointsObj.name = 'Hit';
// Setting uuid for selection from collections info
hitsParams.uuid = pointsObj.uuid;
Expand All @@ -320,7 +322,7 @@ export class PhoenixObjects {
private static hitsToLines(
pointPos: any,
hitsParams: any,
hitParamsClone: any
_hitParamsClone: any
): Object3D {
// geometry
const geometry = new BufferGeometry();
Expand All @@ -333,7 +335,9 @@ export class PhoenixObjects {
});
// object
const linesObj = new LineSegments(geometry, material);
linesObj.userData = Object.assign({}, hitParamsClone);
// Disabling for now because the data isn't readable on object selection.
// linesObj.userData = Object.assign({}, hitParamsClone);
linesObj.userData = {};
linesObj.name = 'Hit';
// Setting uuid for selection from collections info
hitsParams.uuid = linesObj.uuid;
Expand Down

0 comments on commit 8b994a7

Please sign in to comment.