dt-6044 bike stations ids #4872
Conversation
app/util/citybikes.js
Outdated
| /** * | ||
| * Parse id number from stationId. | ||
| */ | ||
| export const parseVehicleIdNumber = stationId => { |
There was a problem hiding this comment.
There is actually a feedScopedIdUtils.js file with getIdWithoutFeed function that we could use instead of this. There is a small upside in having a specific util for this purpose as then it's more clear what we want to get out of the id but still I think maybe we should just reuse the existing util.
…enamed from bike to vehicle."" This reverts commit dfc73f3.
app/component/CityBikeLeg.js
Outdated
There was a problem hiding this comment.
Rename this to VehicleRentalLeg.js
There was a problem hiding this comment.
Rename this to be VehicleRentalStationStopContent.js
app/util/citybikes.js
Outdated
There was a problem hiding this comment.
Rename this to be vehicleRentalUtils.js
| BIKESTATION_OFF, | ||
| BIKESTATION_CLOSED, |
There was a problem hiding this comment.
These constant values can be removed from the citybikes.js (including BIKESTATION_ON also) as they are no longer used.
| path = `/${PREFIX_BIKESTATIONS}/`; | ||
| id = searchObj.properties.labelId; | ||
| break; | ||
| case 'bikestation': | ||
| path = `/${PREFIX_BIKESTATIONS}/`; | ||
| id = searchObj.properties.id; | ||
| break; | ||
| case 'favouriteBikestation': | ||
| case 'favouriteBikeRentalStation': |
There was a problem hiding this comment.
There are still some references to this in code. Not sure if the same or different thing.
…RentalStation Also, lift major version
Proposed Changes
Pull Request Check List
Review