Read route short names in lower case #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vesameskanen
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Lisäksi pari muuta asiaa:
- Haku lukee edelleen M1, katso saisitko korjattua
- toLowerCase tehdään sumeilematta joka paikassa, vaikka propsit tai niiden kentät saattaa olla null/undefined. Tämä kaataa UI:n jos data ei ole tavanomaista. Tarkista milloin on tuvallista tehdä tuo lowe case konversio ja muuta koodia sen mukaisesti.
app/component/AlternativeLegsInfo.js
Outdated
| @@ -17,11 +17,26 @@ const AlternativeLegsInfo = ({ legs, showAlternativeLegs, toggle }) => { | |||
| )) || | |||
| (legs.length > 1 ? ( | |||
| <FormattedMessage | |||
| aria-hidden="true" | |||
There was a problem hiding this comment.
miksi tässä on aria-hidden?
| @@ -57,7 +57,7 @@ const LegInfo = ( | |||
| aria-label={`${intl.formatMessage({ | |||
| id: mode.toLowerCase(), | |||
| defaultMessage: 'Vehicle', | |||
| })} ${leg.route && leg.route.shortName}}`} | |||
| })} ${leg.route && leg.route.shortName.toLowerCase()}}`} | |||
| > | |||
There was a problem hiding this comment.
vanha bugi: ruudun lukija lukee route m1 curly bracket. fiksaatko.
|
resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pull Request Check List
Review