Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-6006: font fix #4915

Merged
merged 6 commits into from
Jan 3, 2024
Merged

DT-6006: font fix #4915

merged 6 commits into from
Jan 3, 2024

Conversation

Dvun
Copy link
Contributor

@Dvun Dvun commented Jan 2, 2024

Proposed Changes

  • The Roboto font turned out to be too pale, so changed it to the montserrat font only

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emme voi vaihtaa koko fonttia noin vain.

Oikea korjaus on tehdä disruptions.scss tyylien alert-body luokan font-weight määrittely muuttujasta riippuvaksi. Oletusarvo on 200, mutta matka.fi teemassa sen arvo pitää olla 400.

https://github.com/HSLdevcom/digitransit-ui/blob/v3/sass/themes/default/_theme.scss
https://github.com/HSLdevcom/digitransit-ui/blob/v3/sass/themes/matka/_theme.scss

@vesameskanen vesameskanen merged commit 2cd76d2 into v3 Jan 3, 2024
6 checks passed
@vesameskanen vesameskanen deleted the DT-6006 branch January 3, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants