DT-6175 part 3 - more refactoring #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not pass redundant props - do not refilter already filtered itineraries - refactor
- Filter once after fetching data, not at every access - Merge bike + public itineraries into single array - Reduce endless and confusing use of derived state variables
- export named functions - add utility function to extract leg mode
Also, fix some prop type errors, and simplify state variable use
optionsome
requested changes
Jan 18, 2024
There was a problem hiding this comment.
There is a conflict.
Pure bicycle itineraries don't show up anymore.
with HSL config (cars enabled) the following itinerary search crashed: /reitti/Valittu sijainti%3A%3A60.350679325290315%2C24.472990036010742/Valittu sijainti%3A%3A60.16536744905669%2C24.84404146671295?time=1705615030 with stack trace:
Uncaught TypeError: leg is undefined
getExtendedMode webpack:///./app/util/legUtils.js?:512
StreetModeSelectorButton webpack:///./app/component/StreetModeSelectorButton.js?:59
React 11
unstable_runWithPriority webpack:///./node_modules/scheduler/cjs/scheduler.development.js?:653
React 6
queryAdditionalItineraries webpack:///./app/component/ItineraryPage.js?:453
[5f6a84d5c3494fabb042.js line 59 > eval:512:41](http://localhost:8080/proxy/js/5f6a84d5c3494fabb042.js%20line%2059%20%3E%20eval)
getExtendedMode webpack:///./app/util/legUtils.js?:512
Other improvements: - more renaming to make things understandable - reduce use of unnecessary duplicate state variables
- filter relaxed plan after query, not when accessing it - remove silly complex looking 'nop' functions - use bettern names
Prop change processing seems to check topics and subscribe if necessary
- remove nonsense check which compares config change - sensible loading state management - rename and simplify
Itinerary page has 50% less code than before, and basic functionality works. Error messages and notifiers still need refactoring.
optionsome
reviewed
Jan 25, 2024
optionsome
reviewed
Jan 26, 2024
| @@ -31,14 +32,14 @@ export const StreetModeSelectorButton = ( | |||
| const duration = durationToString(itinerary.duration * 1000); | |||
| let distance = 0; | |||
| switch (name) { | |||
| case 'WALK': | |||
| case streetHash.walk: | |||
There was a problem hiding this comment.
Why was it 'WALK'? Does this work?
optionsome
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.