Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dt-6189 new lappeenranta favicon #4941

Merged
merged 2 commits into from
Jan 31, 2024
Merged

chore: dt-6189 new lappeenranta favicon #4941

merged 2 commits into from
Jan 31, 2024

Conversation

sharhio
Copy link
Contributor

@sharhio sharhio commented Jan 31, 2024

Proposed Changes

  • Lappeenranta favicon update

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

vesameskanen
vesameskanen requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vanha favicon pitää poistaa

@vesameskanen vesameskanen merged commit 8233ca1 into v3 Jan 31, 2024
4 checks passed
@vesameskanen vesameskanen deleted the DT-6189 branch January 31, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vesameskanen vesameskanen vesameskanen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharhio @vesameskanen