Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-6230 Simplify UI github actions #4942

Merged
merged 6 commits into from
Jan 31, 2024
Merged

DT-6230 Simplify UI github actions #4942

merged 6 commits into from
Jan 31, 2024

Conversation

optionsome
Copy link
Member

Proposed Changes

  • This makes dev github actions pipeline more generic so it can be run on any branch by just adding the branch name to the branches that the action runs on when pushed
    • Docker image's tag will always be the branch name
    • NPM publish is only done on v3 branch push

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@vesameskanen vesameskanen merged commit 5db2dc2 into v3 Jan 31, 2024
6 checks passed
@vesameskanen vesameskanen deleted the DT-6230 branch January 31, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@optionsome @vesameskanen