-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT-6586 Manual start for Navigator journey #5242
Conversation
return ( | ||
<button | ||
type="button" | ||
className={`navi-top-card ${cardExpanded ? 'expanded' : ''}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nicer to use the classnames library for this (and other similar strings).
Like this:
className={cx('navi-top-card', {expanded: cardExpanded})}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far I've used cx for cases where there's two or classes which are assigned based on condition. In single cases such as this I find it doesn't really clarify things, and the function call overhead cannot be easily justified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that when itinerary has a walk leg at start and you start the trip early, walk instructions appear immediately, then slide up and return again. This is undesirable. Is that something top be fixed in a new PR or should it be fixed within this PR?
This issue also occurs whenever cards are swapped during a trip, so I feel like it may deserve a ticket/fix of its own. |
Proposed Changes
<button>
element fromNaviCardContainer
intoNaviCard
as the element is tightly coupled with the card.forceStart
flag is added to the transit leg object which is then used as a signal to instruct the user to wait for their transitPull Request Check List
Review