Fix lora specific conditions in profile-run #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madamczykhabana
approved these changes
Sep 23, 2024
|
@SanjuCSudhakaran please rename variables as we discussed, will merge it then. |
SanjuCSudhakaran
force-pushed
the
fix-lora-profile-run
branch
from
bbb5590 to
a844837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#256 breaks LoRA specific flow which was handled through
is_profile_runflag to distinguish warmup and profile-run phase.Introduces a new flag
is_lora_profile_runto handle this LoRA specific flow in profile-run.