Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seed_everything function doesn't handle HPU #384

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

SanjuCSudhakaran
Copy link

@SanjuCSudhakaran SanjuCSudhakaran commented Oct 11, 2024

This PR adds manual seed setting for HPU in the function seed_everything.

Previously the torch.manual_seed was getting set to the given seed, which got removed in the following PR 6ffa3f3

Copy link

@vivekgoe vivekgoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But you please add short description of problem this fixes in the PR description section, this will help to clarify reason for making this change to other reviewers also.

@michalkuligowski michalkuligowski merged commit d8f2aa7 into habana_main Oct 14, 2024
19 checks passed
@michalkuligowski michalkuligowski deleted the fix-seed branch October 14, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants