[bucketing overhaul 1/n] Add padding-aware scheduling and option to limit prefill batch size #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdamaszk
reviewed
Oct 15, 2024
kzawora-intel
changed the title
madamczykhabana
approved these changes
Oct 17, 2024
xuechendi
added a commit
to xuechendi/vllm-fork
that referenced
this pull request
Oct 23, 2024
…ion to limit prefill batch size (HabanaAI#394)" This reverts commit 05bcdf5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds following functionality that can be enabled via engine flags:
max_num_prefill_seqs. If unset, max prefill batch size will bemax_num_seqs.Both features are generic and do not require HPU, although they may be specialized for particular vendor's usage. Padding aware scheduling includes padding function selector which selects HPU padding function (considering currently used HPU buckets) if current device is HPU. Otherwise, it will take a product of batch_size x max_seq_len.