Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value for FSDPA #448

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

madamczykhabana
Copy link

No description provided.

@madamczykhabana madamczykhabana marked this pull request as draft October 30, 2024 13:11
@madamczykhabana madamczykhabana marked this pull request as ready for review October 30, 2024 13:12
Copy link

@afierka-intel afierka-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madamczykhabana madamczykhabana merged commit 94858b5 into habana_main Oct 30, 2024
19 checks passed
@madamczykhabana madamczykhabana deleted the dev/madamczyk/fix_fsdpa_check branch October 30, 2024 13:21
imangohari1 pushed a commit to imangohari1/vllm-fork that referenced this pull request Oct 31, 2024
@kzawora-intel kzawora-intel added the habana Issues or PRs submitted by Habana Labs label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
habana Issues or PRs submitted by Habana Labs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants