Align fork with HPU upstream code #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-project#6143) Signed-off-by: yuwenzho <[email protected]> Signed-off-by: Chendi.Xue <[email protected]> Signed-off-by: Bob Zhu <[email protected]> Signed-off-by: zehao-intel <[email protected]> Signed-off-by: Konrad Zawora <[email protected]> Co-authored-by: Kunshang Ji <[email protected]> Co-authored-by: Sanju C Sudhakaran <[email protected]> Co-authored-by: Michal Adamczyk <[email protected]> Co-authored-by: Marceli Fylcek <[email protected]> Co-authored-by: Himangshu Lahkar <[email protected]> Co-authored-by: Vivek Goel <[email protected]> Co-authored-by: yuwenzho <[email protected]> Co-authored-by: Dominika Olszewska <[email protected]> Co-authored-by: barak goldberg <[email protected]> Co-authored-by: Michal Szutenberg <[email protected]> Co-authored-by: Jan Kaniecki <[email protected]> Co-authored-by: Agata Dobrzyniewicz <[email protected]> Co-authored-by: Krzysztof Wisniewski <[email protected]> Co-authored-by: Dudi Lester <[email protected]> Co-authored-by: Ilia Taraban <[email protected]> Co-authored-by: Chendi.Xue <[email protected]> Co-authored-by: Michał Kuligowski <[email protected]> Co-authored-by: Jakub Maksymczuk <[email protected]> Co-authored-by: Tomasz Zielinski <[email protected]> Co-authored-by: Sun Choi <[email protected]> Co-authored-by: Iryna Boiko <[email protected]> Co-authored-by: Bob Zhu <[email protected]> Co-authored-by: hlin99 <[email protected]> Co-authored-by: Zehao Huang <[email protected]> Co-authored-by: Andrzej Kotłowski <[email protected]> Co-authored-by: Yan Tomsinsky <[email protected]> Co-authored-by: Nir David <[email protected]> Co-authored-by: Yu-Zhou <[email protected]> Co-authored-by: Ruheena Suhani Shaik <[email protected]> Co-authored-by: Karol Damaszke <[email protected]> Co-authored-by: Marcin Swiniarski <[email protected]> Co-authored-by: Woosuk Kwon <[email protected]> Co-authored-by: Jacek Czaja <[email protected]> Co-authored-by: Jacek Czaja <[email protected]> Co-authored-by: Yuan <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -569,7 +569,8 @@ | |||
| # This avoids race conditions with ray. | |||
| # see https://github.com/vllm-project/vllm/issues/8204 | |||
| sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) | |||
| sock.bind(("", args.port)) | |||
| sock.bind((args.host or "", args.port)) | |||
Check warning
Code scanning / CodeQL
Binding a socket to all network interfaces Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 3 months ago
To fix the problem, we need to bind the socket to a specific network interface instead of all interfaces. This can be achieved by modifying the sock.bind call to use a specific IP address. The best way to do this without changing existing functionality is to use the IP address provided in the args.host parameter. If args.host is not provided, we should raise an error or use a default secure IP address.
- Modify the
sock.bindcall on line 572 to useargs.hostdirectly. - Ensure that
args.hostis not an empty string or0.0.0.0. If it is, raise an error or use a default secure IP address.
Suggested changeset
1
vllm/entrypoints/openai/api_server.py
| @@ -571,3 +571,5 @@ | ||
| sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) | ||
| sock.bind((args.host or "", args.port)) | ||
| if not args.host or args.host in ["", "0.0.0.0"]: | ||
| raise ValueError("Invalid host address. Please provide a specific IP address.") | ||
| sock.bind((args.host, args.port)) | ||
| sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) |
Copilot is powered by AI and may make mistakes. Always verify output.
kzawora-intel
force-pushed
the
private/kzawora/align_upstream
branch
from
15541b2 to
843ae37
Compare
michalkuligowski
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vllm-project#6143 got merged, but it's based on an older revision of HPU components. This PR aligns the two.