Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warmup for multi-step scheduling #501

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

tzielinski-habana
Copy link

Fixed warmup for multi-step scheduling.

Copy link

@mswiniarsk mswiniarsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -1491,7 +1491,27 @@ def warmup_scenario(self,
profiler.start()
for _ in range(times):
inputs = self.prepare_model_input(seqs)
self.execute_model(inputs, kv_caches, warmup_mode=True)
is_single_step = \
self.vllm_config.scheduler_config.num_scheduler_steps == 1
Copy link

@michalkuligowski michalkuligowski Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is self.vllm_config.scheduler_config.is_multi_step, no need to use counter and compare with 1

@tzielinski-habana tzielinski-habana merged commit ea8a23a into habana_main Nov 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants