Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL API #159

Merged
merged 14 commits into from
Oct 2, 2017
Merged

GraphQL API #159

merged 14 commits into from
Oct 2, 2017

Conversation

illegalprime
Copy link
Member

@illegalprime illegalprime commented Sep 22, 2017 •
edited
Loading

Can merge!

@hackgbot
Copy link

Hey y'all! A deployment of this PR can be found here:
https://registration-graphql-v2.pr.hack.gt

@illegalprime illegalprime changed the title First pass on simple cas-graphql. First pass on simple cas & graphql. Sep 22, 2017
@petschekr petschekr added enhancement Adds or suggests a new feature, rewrite, or other enhancement to the codebase pending review This PR is pending review by a maintainer labels Sep 23, 2017
@illegalprime illegalprime changed the base branch from master to export-to-checkin September 26, 2017 07:15
@illegalprime
Copy link
Member Author

Merge #155 first.

@illegalprime illegalprime mentioned this pull request Sep 26, 2017
Closed
@illegalprime illegalprime changed the title First pass on simple cas & graphql. GraphQL API Sep 26, 2017
@illegalprime
Copy link
Member Author

illegalprime commented Sep 30, 2017 •
edited
Loading

note: need better searching feature, like checkin does with regex, maybe this should go in another PR.

@illegalprime illegalprime changed the base branch from export-to-checkin to master September 30, 2017 20:34
@illegalprime
Copy link
Member Author

note: also maybe rename user query to find_user so there's no user { user in checkin

petschekr
petschekr reviewed Oct 1, 2017
View reviewed changes
server/branch.ts
@@ -213,7 +231,7 @@ export class BranchConfig {
await this.loadAllBranches();
return true;
}
catch {
catch (err) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript 2.5.x supports this type of try / catch syntax if you don't need the error variable

petschekr
petschekr reviewed Oct 1, 2017
View reviewed changes
server/tsconfig.json
@@ -7,6 +7,7 @@
],
"target": "es6",
"lib": [
"esnext.asynciterable",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen this library flag used before. What does it enable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It enables a new-ish feature asynciterable which is an iterator that has an async next() method, so you can iterate over things that return promises.

petschekr
petschekr approved these changes Oct 1, 2017
View reviewed changes
Copy link
Member

@petschekr petschekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works well although the API could be fleshed out some more. Does this count as a major version bump or just a minor version (i.e. 2.x.x vs. 1.11.x)?

@petschekr petschekr removed the pending review This PR is pending review by a maintainer label Oct 1, 2017
petschekr
petschekr requested changes Oct 2, 2017
View reviewed changes
Copy link
Member

@petschekr petschekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we switch to https://github.com/apollographql/apollo-codegen instead of the hacky fork currently being used?

@illegalprime
Copy link
Member Author

@petschekr apollo-codegen only supports client-side code, see ardatan/graphql-tools#404.

@petschekr
Copy link
Member

Ah ok I didn't realize that
I'll merge this now

@petschekr petschekr merged commit ef1fc16 into master Oct 2, 2017
@illegalprime illegalprime mentioned this pull request Oct 3, 2017
Closed
@petschekr petschekr deleted the graphql-v2 branch October 7, 2017 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petschekr petschekr petschekr approved these changes

@ehsanmasdar ehsanmasdar Awaiting requested review from ehsanmasdar

Assignees

@illegalprime illegalprime

Labels
enhancement Adds or suggests a new feature, rewrite, or other enhancement to the codebase high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illegalprime @hackgbot @petschekr