Require user logged in for POSTing confirm endpoint #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey y'all! A deployment of this PR can be found here: |
petschekr
approved these changes
Jul 20, 2018
petschekr
requested changes
Jul 20, 2018
server/routes/auth.ts
Outdated
| @@ -70,7 +70,7 @@ export async function reloadAuthentication() { | |||
| } | |||
|
|
|||
| // These routes need to be redefined on every instance of a new router | |||
| router.post("/confirm", validateAndCacheHostName, postParser, async (request, response) => { | |||
| router.post("/confirm", authenticateWithReject, validateAndCacheHostName, postParser, async (request, response) => { | |||
There was a problem hiding this comment.
Because this middleware is using !request.user.verifiedEmail || !request.user.accountConfirmed to check if a user is valid, a confirming user will always be rejected.
There was a problem hiding this comment.
Good catch, switched to explicitly validating
rahulrajus
pushed a commit
that referenced
this pull request
Jul 22, 2021
* Require user logged in for POSTing confirm endpoint * Don't use middleware to validate user * Version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.