Consolidate API requests authed with bearer to a single function call #279
Conversation
Also finally fixes problems with logout not being communicated to Ground Truth
petschekr
force-pushed
the
fix-bearer-calls
branch
from
34c1cd1 to
1502ab6
Compare
|
|
||
| req.end(); | ||
| // Invalidates token and logs user out of Ground Truth too | ||
| await GroundTruthStrategy.apiRequest("POST", new URL("/api/user/logout", groundTruthURL).toString(), user.token || ""); |
There was a problem hiding this comment.
Do we want to log the user out of GT if they log out of registration? CAS (ie login.gatech.edu) would typically keep you logged in but redirect you to a page that gives you the option to completely log out of the CAS.
There was a problem hiding this comment.
I implemented it this way because typically people want to sign out of registration + Ground Truth (i.e. to switch accounts or for security or whatever) when they click "Log out" from within registration and combining it into a single, automatic step seemed easier. I don't really see a use case for wanting to log out of registration but not Ground Truth
server/routes/strategies.ts
Outdated
| reject(error); | ||
| } | ||
| else { | ||
| resolve(body as string); |
There was a problem hiding this comment.
Do we have some endpoints that don't return JSON?
There was a problem hiding this comment.
Good point - updated method to always return parsed JSON
Consolidate API requests authed with bearer to a single function call
Also finally fixes problems with logout not being communicated to Ground Truth
A continuation of #276