Mainline Help Scout features #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added very basic initial functionality * Implemented hmac hash checking (maybe?) * Basic hello world to test signature validation in test deploy * Add Help Scout secret * Add more debugging * Updated to latest version of typescript, fixed Help Scout signature validation * Pushing some more changes to see how they look * Make time zone questions required * Testing some more * Make timezone questions required * Fix punctuation in dates * Lots of Help Scout integration UI element improvements * Finishing touches for Help Scout integration * Help Scout Beacon support improvements * Add info about Help Scout integration/Beacon to README * Apparently you can't define secrets in both deployment.yaml and a Beehive yaml * Remove package script that doesn't work * Upgraded packages, including Handlebars * Re-implemented Help Scout templates using Handlebars * Show selected application/confirmation questions in Help Scout * Cleanup Help Scout API security * Remove extra lines * A few final fixes and tweaks * Make time zone questions required * test file questions help scout view * Fix file helpscout download URL * actually fix help scout file links * Remove some console.logs * minor fixes Co-authored-by: Evan Strat <[email protected]> Co-authored-by: Stephanie A <[email protected]> Co-authored-by: Evan Strat <[email protected]> Co-authored-by: Stephanie A <[email protected]> # Conflicts: # package-lock.json # server/config/questions.json
Stephanie-A
approved these changes
Nov 2, 2020
|
Any updates on this? Can we get it merged? |
|
It should be good, I will take a look in the next couple of days. |
rahulrajus
pushed a commit
that referenced
this pull request
Jul 22, 2021
* Add new Help Scout integration and Beacon functionality (#304) (#308) * Added very basic initial functionality * Implemented hmac hash checking (maybe?) * Basic hello world to test signature validation in test deploy * Add Help Scout secret * Add more debugging * Updated to latest version of typescript, fixed Help Scout signature validation * Pushing some more changes to see how they look * Make time zone questions required * Testing some more * Make timezone questions required * Fix punctuation in dates * Lots of Help Scout integration UI element improvements * Finishing touches for Help Scout integration * Help Scout Beacon support improvements * Add info about Help Scout integration/Beacon to README * Apparently you can't define secrets in both deployment.yaml and a Beehive yaml * Remove package script that doesn't work * Upgraded packages, including Handlebars * Re-implemented Help Scout templates using Handlebars * Show selected application/confirmation questions in Help Scout * Cleanup Help Scout API security * Remove extra lines * A few final fixes and tweaks * Make time zone questions required * test file questions help scout view * Fix file helpscout download URL * actually fix help scout file links * Remove some console.logs * minor fixes Co-authored-by: Evan Strat <[email protected]> Co-authored-by: Stephanie A <[email protected]> Co-authored-by: Evan Strat <[email protected]> Co-authored-by: Stephanie A <[email protected]> # Conflicts: # package-lock.json # server/config/questions.json * Fix compile errors * Finishing touches * clarify Co-authored-by: Evan Strat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the changes in #304 to master