Class21/week2 #401
Class21/week2 #401
Conversation
| if (error) { | ||
| console.log(error); | ||
| } | ||
| const todoList = JSON.parse(toDos); |
| @@ -0,0 +1,77 @@ | |||
| const program = require('commander'); | |||
There was a problem hiding this comment.
It was very new, I hope I could do it properly.
week2/homework/bonus/bonus.js
Outdated
| return fs.writeFile('./bonus/list.json', newList, error => console.log(error)); | ||
| }); | ||
| }) | ||
| // The `update` takes only one argument, the second one is `undefined`. |
There was a problem hiding this comment.
Looks like a known issue. It is suggested to use program.args tj/commander.js#53 (comment)
There was a problem hiding this comment.
I tried this one but it didn't work at all for some reason.
program
.command('update')
.usage(' [new value...]')
.description('update one todo item')
.action(function(todoItem, newVal) {
fs.readFile('./bonus/list.json', 'utf8', (error, toDos) => {
if (error) {
console.log(error);
}
const todoList = JSON.parse(toDos);
const mappedList = todoList.map((elem, index) =>
index === Number(todoItem) - 2 ? newVal : elem,
);
const newList = JSON.stringify(mappedList, null, 2);
console.log(newList);
return fs.writeFile('./bonus/list.json', newList, error => console.log(error));
});
});
node bonus . update 2 "Do something else"
It does not make any changes and no messages at all in the console
There was a problem hiding this comment.
hmm, well no big deal, it is not your fault, it is an error in the library
week2/homework/bonus/bonus.js
Outdated
| } | ||
| const todoList = JSON.parse(toDos); | ||
| const mappedList = todoList.map((elem, index) => | ||
| index === Number(todoItem) - 2 ? newVal : elem, |
There was a problem hiding this comment.
To reach todoItem by its line number. The first line of the json file is [ and the first todoItem is line 2
There was a problem hiding this comment.
But you are using the index for the json array not for the line number in the file
There was a problem hiding this comment.
So -1 will be enough this way.
I'll do that.
|
|
||
| // TODO: Write the homework code in this file | ||
| const help = require('./help'); |
There was a problem hiding this comment.
separate files for each command 👍
| list().then(toDos => console.log(toDos)); | ||
| break; | ||
| case 'add': | ||
| add(todoItem).then(toDos => console.log(toDos)); |
| function list() { | ||
| return new Promise((resolve, reject) => { | ||
| fs.readFile(fileName, 'utf8', (error, toDos) => { | ||
| error ? reject(error) : resolve(toDos); |
week2/homework/src/update.js
Outdated
|
|
||
| function update(todoItem, newVal) { | ||
| return new Promise((resolve, reject) => { | ||
| list().then(toDos => { |
There was a problem hiding this comment.
what if list throws an error?
There was a problem hiding this comment.
The list() handles errors itself and the writeFile handles it as well, is not that enough?!
There was a problem hiding this comment.
list() rethrows the error, so it needs to be handled here
There was a problem hiding this comment.
So I have to use the .catch to solve it
There was a problem hiding this comment.
`.catch(error => console.log(error));`
| const fs = require('fs'); | ||
| const fileName = './src/data.json'; | ||
|
|
||
| function list() { |
There was a problem hiding this comment.
separate function for loading the file 👍
No description provided.