HackerOne specific changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvgijssel
commented
Oct 25, 2021
| @@ -116,8 +116,7 @@ def sync_method_for_streams(streams, state, default_replication_method): | |||
| continue | |||
|
|
|||
| if replication_method == 'LOG_BASED' and stream_metadata.get((), {}).get('is-view'): | |||
| raise Exception(f'Logical Replication is NOT supported for views. ' \ | |||
| f'Please change the replication method for {stream["tap_stream_id"]}') | |||
| continue | |||
There was a problem hiding this comment.
This is a quick fix for not having to specify each entity that's a view in the Meltano select. Long term we can look at downloading the catalog, modifying all streams marked as views and use a custom catalog for the extractor.
mvgijssel
force-pushed
the
add-replica-option
branch
from
7516ab5 to
a073f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HackerOne necessary changes