Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #173: Error message if bower.json missing #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX #173: Error message if bower.json missing #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions lib/service/packageDetailsProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,28 @@ module.exports = function PackageDetailsProvider() {
utils.exec('git clone {0} {1} --depth=1'.format(packageUrl, gitCloneFolder))
.then(function() {
var bowerJsonLocation = path.join(gitCloneFolder, 'bower.json');

var fileContent = fs.readFileSync(bowerJsonLocation);
var bowerJson = JSON.parse(fileContent);

var bowerJsonIsExist = true;
var fileContent;
var bowerJson;

try {
fs.accessSync(bowerJsonLocation);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not read the file here and if it didn't happen throw an Error :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And PR-s should be directed to the next version branch

}
catch (e) {
bowerJsonIsExist = false;
}

if (bowerJsonIsExist) {
fileContent = fs.readFileSync(bowerJsonLocation);
bowerJson = JSON.parse(fileContent);
}
else {
bowerJson = 'Not found bower.json in this package';

}

utils.removeDirectory(gitCloneFolder);

resolve(bowerJson);
})
.catch(reject);
Expand Down