updated aws_eks_create_custom_ami.sh

HariSekhon · Jan 31, 2025 · 0773a7e · 0773a7e
1 parent e342bfb
commit 0773a7e
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/aws/aws_eks_create_custom_ami.sh b/aws/aws_eks_create_custom_ami.sh
@@ -87,17 +87,18 @@ for((i=1; i <= 100 ; i++)); do
             --output text
     )"
 
-    timestamp "Checking the instance state isn't terminated"
-    instance_state="$(
-        aws ec2 describe-instances \
-            --instance-ids "$instance_id" \
-            --query "Reservations[0].Instances[0].State.Name" \
-            --output text
-    )"
-    if [ "$instance_id" != "None" ] &&
-       [ "$instance_state" = "terminated" ]; then
-        timestamp "This instance is already terminated, will try a new instance name"
-        continue
+    if [ "$instance_id" != "None" ]; then
+        timestamp "Checking the instance state isn't terminated"
+        instance_state="$(
+            aws ec2 describe-instances \
+                --instance-ids "$instance_id" \
+                --query "Reservations[0].Instances[0].State.Name" \
+                --output text
+        )"
+        if [ "$instance_state" = "terminated" ]; then
+            timestamp "This instance is already terminated, will try a new instance name"
+            continue
+        fi
     fi
 
     if is_blank "$instance_id" || [ "$instance_id" = "None" ]; then