Adding Pre-commit Hooks & Improving Prettier/ESLint rules #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriszyp
requested changes
Dec 2, 2024
|
|
@kriszyp Updated PR 🙂 |
kriszyp
approved these changes
Dec 2, 2024
| "quoteProps": "consistent", | ||
| "singleQuote": true, | ||
| "trailingComma": "es5", | ||
| "useTabs": true, |
There was a problem hiding this comment.
I presume you are going to have a lot of whitespace updates in your commits going forward with this. Do you want that?
There was a problem hiding this comment.
Hmmm 🤔 I'll look into:
- Creating a separate PR running prettier & ESLint on the entire app
and/or - Investigating if it's possible to run prettier and not affect the git history
There was a problem hiding this comment.
Usually the strategy is to add (mass) prettier/lint commits in .git-blame-ignore-revs: https://github.com/HarperDB/harperdb/blob/main/.git-blame-ignore-revs
I just didn't know if you really wanted to do that right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
"prettier --write --ignore-unknown"&"eslint --fix"run as pre-commit hooks