Fibonacci Search in C++ #2265
Fibonacci Search in C++ #2265
Conversation
| 2. | ||
| Enter Size Of Arrary: | ||
| 4 | ||
| Enter Elements In Array | ||
| 1 2 3 4 | ||
| Enter The Element To Be Searched | ||
| 5 | ||
| Element Not Found | ||
|
|
There was a problem hiding this comment.
Remove this. One sample I/O does the trick
| int n; /* size of array */ | ||
| cout<<"Enter Size Of Arrary:"<<"\n"; | ||
| cin>>n; | ||
|
|
||
| int arr[n]; /* array declaration */ | ||
| cout<<"Enter Elements In Array"<<"\n"; | ||
|
|
||
| for(int i=0;i<n;i++) | ||
| { | ||
| cin>>arr[i]; | ||
| } | ||
|
|
||
| int element; /* Element that user want's to search */ | ||
| cout<<"Enter The Element To Be Searched"<<"\n"; | ||
| cin>>element; | ||
|
|
||
| int index = fibonacciSearch(arr,n,element); /* Call fibonacci search function */ | ||
|
|
||
| if(index==-1) | ||
| cout<<"Element Not Found"<<"\n"; /* if element is not present */ | ||
| else | ||
| cout<<"Element Found At Array Index : "<<index; /* if Present print index*/ | ||
|
|
||
| return 0; |
There was a problem hiding this comment.
Indent the Code. In fact, run a formatter on the whole code
| /* if found return index */ | ||
| else return i; | ||
| } | ||
| /* check for last array element */ |
There was a problem hiding this comment.
Use // ....... for single line comments only
| fibM1 = fibM1 - fibM2; | ||
| fibM2 = fibM - fibM1; | ||
| } | ||
| /* if found return index */ |
There was a problem hiding this comment.
Use // ....... for single line comments only
|
|
||
| int fibonacciSearch(int arr[],int n,int element) | ||
| { | ||
| /* Initializing fibonacci no */ |
There was a problem hiding this comment.
Use // ....... for single line comments only
| Time Complexity : O(log(n)) | ||
| Auxiliary Space : O(1) |
There was a problem hiding this comment.
Keep complexities at the end of the code
|
Sure! |
| Time Complexity : O(log(n)) | ||
| Auxiliary Space : O(1) | ||
|
|
||
| */ |
| if (index == -1) | ||
| cout << "Element Not Found" << "\n"; // if element is not present | ||
| else | ||
| cout << "Element Found At Array Index : " << index; // if Present print index |
There was a problem hiding this comment.
Use comments above the line of code not beside it.
| int index = fibonacciSearch(arr, n, element); // Call fibonacci search function | ||
|
|
||
| if (index == -1) | ||
| cout << "Element Not Found" << "\n"; // if element is not present |
There was a problem hiding this comment.
Use comments above the line of code not beside it.
| cout << "Enter The Element To Be Searched" << "\n"; | ||
| cin >> element; | ||
|
|
||
| int index = fibonacciSearch(arr, n, element); // Call fibonacci search function |
There was a problem hiding this comment.
Use comments above the line of code not beside it.
| cin >> arr[i]; | ||
| } | ||
|
|
||
| int element; // Element that user want's to search |
There was a problem hiding this comment.
Use comments above the line of code not beside it.
| } | ||
|
|
||
| int main() { | ||
| int n; // size of array |
There was a problem hiding this comment.
Use comments above the line of code not beside it.
| cout << "Enter Size Of Arrary:" << "\n"; | ||
| cin >> n; | ||
|
|
||
| int arr[n]; // array declaration |
There was a problem hiding this comment.
Use comments above the line of code not beside it.
ankitaggarwal23
changed the title
HarshCasper
added
Level2
Have you read the Contributing Guidelines on Pull Requests?
YES
Description
I have added Fibonacci search under the search section in c++.
Checklist
README.mdand link to my code.Related Issues or Pull Requests
#2242