Skip to content

Commit

Permalink
Refactoring StreamingReceiver Tests to re-use code across test cases (A…
Browse files Browse the repository at this point in the history
  • Loading branch information
ramya-rao-a authored Jan 14, 2019
1 parent f2aa4d4 commit bfc4665
Show file tree
Hide file tree
Showing 2 changed files with 306 additions and 569 deletions.
24 changes: 13 additions & 11 deletions test/batchReceiver.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ async function testPeekMsgsLength(
expectedPeekLength: number
): Promise<void> {
const peekedMsgs = await client.peek(expectedPeekLength + 1);
should.equal(peekedMsgs.length, expectedPeekLength);
should.equal(
peekedMsgs.length,
expectedPeekLength,
"Unexpected number of msgs found when peeking"
);
}

const maxDeliveryCount = 10;
Expand Down Expand Up @@ -156,7 +160,7 @@ describe("Complete/Abandon/Defer/Deadletter normal message", () => {
await testComplete(queueClient, queueClient);
});

it("Queue: complete() removes message", async function(): Promise<void> {
it("Subscription: complete() removes message", async function(): Promise<void> {
await testComplete(topicClient, subscriptionClient);
});

Expand All @@ -172,13 +176,13 @@ describe("Complete/Abandon/Defer/Deadletter normal message", () => {
await completeMessages(receiverClient, 1);
}

it("Queue: Abandoned message is retained with incremented deliveryCount", async function(): Promise<
it("Queue: abandon() retains message with incremented deliveryCount", async function(): Promise<
void
> {
await testAbandon(queueClient, queueClient);
});

it("Subscription: Abandoned message is retained with incremented deliveryCount", async function(): Promise<
it("Subscription: abandon() retains message with incremented deliveryCount", async function(): Promise<
void
> {
await testAbandon(topicClient, subscriptionClient);
Expand Down Expand Up @@ -209,13 +213,11 @@ describe("Complete/Abandon/Defer/Deadletter normal message", () => {
await testPeekMsgsLength(receiverClient, 0);
}

it("Queue: Receive deferred message from queue/subscription", async function(): Promise<void> {
it("Queue: defer() moves message to deferred queue", async function(): Promise<void> {
await testDefer(queueClient, queueClient);
});

it("Subscription: Receive deferred message from queue/subscription", async function(): Promise<
void
> {
it("Subscription: defer() moves message to deferred queue", async function(): Promise<void> {
await testDefer(topicClient, subscriptionClient);
});

Expand All @@ -232,11 +234,11 @@ describe("Complete/Abandon/Defer/Deadletter normal message", () => {
await completeMessages(deadLetterClient, 0);
}

it("Queue: Receive dead letter message from queue/subscription", async function(): Promise<void> {
it("Queue: deadLetter() moves message to deadletter queue", async function(): Promise<void> {
await testDeadletter(queueClient, queueClient, deadletterQueueClient);
});

it("Subscription: Receive dead letter message from queue/subscription", async function(): Promise<
it("Subscription: deadLetter() moves message to deadletter queue", async function(): Promise<
void
> {
await testDeadletter(topicClient, subscriptionClient, deadletterSubscriptionClient);
Expand Down Expand Up @@ -601,7 +603,7 @@ describe("Multiple ReceiveBatch calls", () => {
});
});

describe("Other ReceiveBatch Tests", function(): void {
describe("Batching Receiver Misc Tests", function(): void {
beforeEach(async () => {
await beforeEachTest();
});
Expand Down
Loading

0 comments on commit bfc4665

Please sign in to comment.