Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch torus and ellipsoid to SymbolicObj3 #450

Closed
sorki opened this issue Nov 7, 2023 · 1 comment
Closed

Switch torus and ellipsoid to SymbolicObj3 #450

sorki opened this issue Nov 7, 2023 · 1 comment

Comments

@sorki
Copy link
Contributor

sorki commented Nov 7, 2023

These are currently implemented "inline" using implicit which makes them unique and opaque to our AST.

This reminded me of the Haskell expression problem https://eli.thegreenplace.net/2018/more-thoughts-on-the-expression-problem-in-haskell/ and one of the solutions Data Types a la Carte

Search for DTalC led me to familiar site https://reasonablypolymorphic.com/blog/better-data-types-a-la-carte/ which offers improved version.

Switching to this representation would allow us and our users to extend our current monolithic AST types with custom ones.
lepsa added a commit to lepsa/ImplicitCAD that referenced this issue Dec 29, 2023
@lepsa
Issue Haskell-Things#450. Making torus and ellipsoid primitive objects.
10d6775 
Switching the definitions of torus and ellipsoid to be SymbolicObj3
primitives rather than being `implict`ly defined. The maths functions
haven't changed, only been moved around.

One test was updated as some of the STL values changed, but to the eye
it looks similar, and a random check of values indicated that they were
small.
@lepsa lepsa mentioned this issue Dec 29, 2023
Merged
julialongtin added a commit that referenced this issue Jan 1, 2024
@julialongtin
Merge pull request #470 from lepsa/torus-and-ellipsoid-as-objects
eacfe58 
Issue #450. Making torus and ellipsoid primitive objects.
@julialongtin
Copy link
Member

done. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorki @julialongtin