Add slice primitive #448
Merged
Add slice primitive #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorki
force-pushed
the
srk/slice
branch
2 times, most recently
from
4095f7e to
9509246
Compare
|
Will add changelog entries after #473 is merged |
julialongtin
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started to implement projection similar to OpenSCAD but got stuck on its base case which is a projection of all points onto a plane, while the
cut = truecase is pretty simple.While reading Ruckus docs I've realized we can have this implemented as
sliceprimitive instead (naming hard..) and even stumbled onMAYBEFIXMEsuggesting exactly that.This probably doesn't belong to 2D or 3D prims but a shared one as outlined in #446.Edit: think it's fine for now sinceextrudeis in 3D prims.Also needs
SymbolicFormatsoutput (while it doesn't make much sense to add it toExtOpenSCADas it is a special case of projection, we can maybe generateprojection(cut = true)(at least for 3D to 2D)